EAM: fix cmake configuration of crm/pam #7008
Conversation
bartgol
added
BFB
|
This is still not fixing the MMF2 fail. It appears that SCREAM_DATA_DIR is undefined by the time cmake generates scream_config.h, causing a runtime error b/c the p3 table filename is ill-formed. I'm digging. |
|
Turns out I needed another PR in PAM. When that goes in, I'll update this branch. Also, we don't need to rm the |
bartgol
force-pushed
the
bartgol/eamxx/rm-eamxx-physics-lib
branch
from
f7ca589 to
7f09c9a
Compare
bartgol
changed the title
Fixes CI error in building MMF case [BFB]
|
The fix did not work. I just pushed another commit, and am trying to build on mappy to ensure this time we got it... Edit: on mappy, the case now builds. It's stuck in the q for the run phase, but at least it now builds. Edit 2: the test passes on mappy. I cleaned up the PR and re-merged to next. |
Gets some CMake fixes when building with EAMxx physics
* EAMxx cmake already declares one * PAM does not need to link against eamxx_physics, as it already links against p3 and shoc
PAM does not include src/physics, so the tgt is never declared
bartgol
force-pushed
the
bartgol/eamxx/rm-eamxx-physics-lib
branch
from
a4ca426 to
ae9120b
Compare
|
Since manually running the MMF2 test passes on mappy, I am going to merge this. SNL jenkins was sick yesterday, and the MMF2 doesn't even build on master now, so merging this can only make things better anyways. |
Fixes CI error in building MMF case (see e.g. this build)
[BFB]
Details: