Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jinyuntang/lnd/ch4 zero bugfix #728

Closed
wants to merge 0 commits into from

Conversation

jinyuntang
Copy link
Contributor

Fixes the bug that results in zero methane flux and
inconsistent carbon isotope tracking for root respiration.

Fixes #720

[non-BFB]

@bishtgautam
Copy link
Contributor

Hi @jinyuntang, There is no need to have four commits be part of ACME history, especially when the third commit reverted the changes made by first two commits. So please squash all four commits into one by https://gist.github.com/bishtgautam/b162199582f9c995f7a8.

@jinyuntang
Copy link
Contributor Author

@bishtgautam, only the last commit is meaningful, can you merge only the last one?

@bishtgautam
Copy link
Contributor

Updated the PR message and removed the following text, which should have been a comment.

The code has been tested for 6-month simulations with compset ICRUCLM45BGC using the f19_g16 grid, with and without active c13 and c14 isotopes.

@bishtgautam
Copy link
Contributor

At present, I can't merge only the last commit. Squashing all four commits into one will result in a single meaningful commit that will be merged.

@jinyuntang
Copy link
Contributor Author

any guidelines to do this?

On Wed, Feb 24, 2016 at 12:31 PM, Gautam Bisht notifications@github.com
wrote:

At present, I can't merge only the last commit. Squashing all four commits
into one will result in a single meaningful commit that will be merged.


Reply to this email directly or view it on GitHub
#728 (comment).

Jinyun

Jinyun Tang, Research Scientist
Lawrence Berkeley National Laboratory
1 Cyclotron Rd., MS 74R316C
Berkeley, CA 94720
tel: 510 486-5792, fax: 510 486-7070

@bishtgautam
Copy link
Contributor

@jinyuntang jinyuntang force-pushed the jinyuntang/lnd/ch4_zero_bugfix branch from 2a2c440 to 52f8a2b Compare February 24, 2016 20:40
@jinyuntang
Copy link
Contributor Author

@bishtgautam. Just updated per your suggestion.

@bishtgautam
Copy link
Contributor

Perfect. Thanks.

@jinyuntang
Copy link
Contributor Author

Good to know. Thanks.

On Wed, Feb 24, 2016 at 12:42 PM, Gautam Bisht notifications@github.com
wrote:

Perfect. Thanks.


Reply to this email directly or view it on GitHub
#728 (comment).

Jinyun

Jinyun Tang, Research Scientist
Lawrence Berkeley National Laboratory
1 Cyclotron Rd., MS 74R316C
Berkeley, CA 94720
tel: 510 486-5792, fax: 510 486-7070

@rljacob rljacob added the Land label Feb 25, 2016
bishtgautam pushed a commit that referenced this pull request Mar 4, 2016
Fixes the bug that results in zero methane flux and
inconsistent carbon isotope tracking for root respiration.

Fixes #720

[non-BFB]
@rljacob rljacob added this to the v1.0 Alpha.4 milestone Mar 5, 2016
bishtgautam pushed a commit that referenced this pull request Mar 7, 2016
Fixes the bug that results in zero methane flux and
inconsistent carbon isotope tracking for root respiration.

Fixes #720

[non-BFB]
@bishtgautam bishtgautam closed this Mar 7, 2016
@bishtgautam bishtgautam force-pushed the jinyuntang/lnd/ch4_zero_bugfix branch from 52f8a2b to c0dc1b5 Compare March 7, 2016 15:56
@bishtgautam bishtgautam deleted the jinyuntang/lnd/ch4_zero_bugfix branch March 7, 2016 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants