-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jinyuntang/lnd/ch4 zero bugfix #728
Conversation
Hi @jinyuntang, There is no need to have four commits be part of ACME history, especially when the third commit reverted the changes made by first two commits. So please squash all four commits into one by https://gist.github.com/bishtgautam/b162199582f9c995f7a8. |
@bishtgautam, only the last commit is meaningful, can you merge only the last one? |
Updated the PR message and removed the following text, which should have been a comment.
|
At present, I can't merge only the last commit. Squashing all four commits into one will result in a single meaningful commit that will be merged. |
any guidelines to do this? On Wed, Feb 24, 2016 at 12:31 PM, Gautam Bisht notifications@github.com
Jinyun Jinyun Tang, Research Scientist |
2a2c440
to
52f8a2b
Compare
@bishtgautam. Just updated per your suggestion. |
Perfect. Thanks. |
Good to know. Thanks. On Wed, Feb 24, 2016 at 12:42 PM, Gautam Bisht notifications@github.com
Jinyun Jinyun Tang, Research Scientist |
Fixes the bug that results in zero methane flux and inconsistent carbon isotope tracking for root respiration. Fixes #720 [non-BFB]
Fixes the bug that results in zero methane flux and inconsistent carbon isotope tracking for root respiration. Fixes #720 [non-BFB]
52f8a2b
to
c0dc1b5
Compare
Fixes the bug that results in zero methane flux and
inconsistent carbon isotope tracking for root respiration.
Fixes #720
[non-BFB]