Add ERS test for COSP #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susburrows
added a commit
that referenced
this pull request
Apr 21, 2016
Add ERS test for COSP [BFB]
|
merged to next |
susburrows
added a commit
that referenced
this pull request
Apr 21, 2016
Add ERS test for COSP [BFB]
agsalin
pushed a commit
that referenced
this pull request
Apr 13, 2017
… into master (PR #895) Test suite: Test baseline: Test namelist changes: Test status: [bit for bit, roundoff, climate changing] Fixes #851 User interface changes?: no Code review: Valgrind is complaining when strncpy or snprintf are used with non-null-terminated strings. To eliminate the issue, strncpy and snprintf are replaced with equivalent character-by-character copy loops in the instances in which the input string is non-null-terminated. While this resolves #851 , the clean-up to t_drvstartf/t_drvstops suggested by @bishtgautam should still be implemented. This is BFB in limited testing using an ACME B case, and should be BFB if not buggy. * origin/worleyph/timing/non-null-terminated_string_support_fix: Update ChangeLog to correct original description of the problem Replace strncpy and snprintf where applied to non-null-term. strings
rljacob
pushed a commit
that referenced
this pull request
May 6, 2021
… into master (PR #895) Test suite: Test baseline: Test namelist changes: Test status: [bit for bit, roundoff, climate changing] Fixes #851 User interface changes?: no Code review: Valgrind is complaining when strncpy or snprintf are used with non-null-terminated strings. To eliminate the issue, strncpy and snprintf are replaced with equivalent character-by-character copy loops in the instances in which the input string is non-null-terminated. While this resolves #851 , the clean-up to t_drvstartf/t_drvstops suggested by @bishtgautam should still be implemented. This is BFB in limited testing using an ACME B case, and should be BFB if not buggy. * origin/worleyph/timing/non-null-terminated_string_support_fix: Update ChangeLog to correct original description of the problem Replace strncpy and snprintf where applied to non-null-term. strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ERS test for COSP
[BFB]