Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminating reference to unallocated arrays in VOCEmissionMod (fixes #81), moving misplaced t_stopf (fixes #94), and replacing pgi version for Titan (fixes #62) #90

Merged
merged 3 commits into from
Feb 3, 2015

Commits on Jan 30, 2015

  1. eliminating reference to unallocated arrays in VOCEmissionMod

      The version of CLM4.5 we imported has a bug (diagnosed and corrected by CSEG
      in bug no 2053) in which arrays are not allocated when in certain circumstances,
      but the same conditions are not checked elsewhere when the arrays are accessed,
      leading to a seg. fault. The fix implemented by CSEG is imported here.
    
      Note that bug fix no. 2053 also involves other changes. These are not adopted
      as we have not yet run into the corresponding problem. There are a number of
      other bug reports and fixes for CLM4.5 that are also not dealt with in this
      commit.
    Patrick Worley committed Jan 30, 2015
    Configuration menu
    Copy the full SHA
    2e65bcf View commit details
    Browse the repository at this point in the history
  2. moving misplaced t_stopf call in CLM4.5

      The timer ecosysdyn was started but not stopped for certain science cases,
      leading to inaccurate	  performance data.
    Patrick Worley committed Jan 30, 2015
    Configuration menu
    Copy the full SHA
    aca65f9 View commit details
    Browse the repository at this point in the history
  3. replacing pgi/14.2.0 with pgi/14.10.home for Titan when using PGI com…

    …piler
    
      CLM45 does not work on Titan unless update to a newer version of PGI.
      (This is also required when building and running with CLM4.5 on Titan.) This is
      ACME github issue #62. This resolves the problem, but is redundant with an identical
      modification in pull request #89.
    Patrick Worley committed Jan 30, 2015
    Configuration menu
    Copy the full SHA
    23bdb67 View commit details
    Browse the repository at this point in the history