cleanup: remove DG and SPELT code

[halldm2000]

removed all DG files from homme/src
removed references to PRIMDG and SWDG and related
tested using HOMME stand-alone tests and FC5AQUAP (aquaplanet)

removed spelt mods from src and src/share
removed spelt tests
removed most references to SPELT using global search
tested using HOMME stand-alone test and FC5AQUAP

[BFB]

[mt5555]

one minor tweak: can you amend your commit message to add [BFB] to the text?

[mrnorman]

All HOMME regression tests identical with master baseline on Titan except for test-baroCamMoistSL and test-swtc6, which are failing in general on Titan right now (including on master). @halldm2000 's tests worked on his local machine and were all identical with baseline as well. Going ahead and integrating, but @mt5555 , we need to look at those two failing tests on Titan. I'll make the output available in world-shared and comment a link to it soon.

[mrnorman]

Just pushed it to next. Will wait for tests.

[mrnorman]

@mt5555 , I put the output directories in /lustre/atlas/world-shared/stf006/imn/FAILED_HOMME_REGRESSION

Both of the failed runs appear to fail because:
189 call abortmp('There is not enough paralellism in the job, that is, there is less than one elements per task.')

[mt5555]

Did you override the default number of MPI tasks? Or it could be that the default is too high.
The ACME regression system runs the HOMME tests on 24 MPI tasks.
If you are running them by hand outside the ACME system, you can add this to your CMAKE configure line:

-DUSE_NUM_PROCS=24

[halldm2000]

No, I didn't remove the FVM struct in this pull request. I'm working on
that now.

On Fri, Jul 29, 2016 at 3:37 PM, Mark Taylor notifications@github.com
wrote:

Did this code remove the "fvm" struct? Just checking, since if that struct
is removed, the atmosphere dp coupling layer also needs to be updated,
otherwise all ACME atmosphere tests will fail.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#957 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALequwTkldxdbcQ0qDvr7Y07NUkjoyl7ks5qanKcgaJpZM4JQASH
.

[mt5555]

100% pass (HOMME tests) on skybridge

[mt5555]

For the record, this worked "out of the box" on Edison:

generate baselines using master:

git checkout master
cd acme/cime/scripts-acme
./create_test -g -b master HOMME_P24.f19_g16_rx1.A

run HOMME tests using next, compare to baselines generated above:

git checkout next
./create_test -c -b master HOMME_P24.f19_g16_rx1.A

[mt5555]

'''
0%] Built target COMPARE_VARS
[ 3%] Built target timing
[ 4%] Built target cprnc
[ 12%] Built target pio
[ 27%] Built target swtcB
[ 43%] Built target swtcA
[ 61%] Built target baroCam-acc
[ 80%] Built target baroC
[100%] Built target baroCam
Scanning dependencies of target check
Test project /scratch1/scratchdirs/taylorm/acme_scratch/HOMME_P24.f19_g16_rx1.A.edison_intel.C.20160730_023035/bld/te
st_execs
Start 1: verifyBaselineResults
1/12 Test #1: verifyBaselineResults ............ Passed 1.43 sec
Start 2: swtc1
2/12 Test #2: swtc1 ............................ Passed 49.28 sec
Start 3: swtc2
3/12 Test #3: swtc2 ............................ Passed 31.44 sec
Start 4: swtc5
4/12 Test #4: swtc5 ............................ Passed 49.36 sec
Start 5: swtc6
5/12 Test #5: swtc6 ............................ Passed 63.68 sec
Start 6: baro2b
6/12 Test #6: baro2b ........................... Passed 103.58 sec
Start 7: baro2c
7/12 Test #7: baro2c ........................... Passed 75.20 sec
Start 8: baro2d
8/12 Test #8: baro2d ........................... Passed 127.04 sec
Start 9: baroCamMoist
9/12 Test #9: baroCamMoist ..................... Passed 114.03 sec
Start 10: baroCamMoistSL
10/12 Test #10: baroCamMoistSL ................... Passed 32.58 sec
Start 11: baroCamMoist-acc
11/12 Test #11: baroCamMoist-acc ................. Passed 38.28 sec
Start 12: templates
12/12 Test #12: templates ........................ Passed 45.48 sec

100% tests passed, 0 tests failed out of 12

Total Test time (real) = 731.57 sec
[100%] Built target check

'''