namelist parameter to set maximum liquidus temperature #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a namelist parameter in place of the currently hardcoded maximum liquidus temperature
@eclare108213
Icepack testing is currently broken on my laptop due an iOS bug that prevents diagnostic files from closing properly, awaiting fixes from the consortium repo. Spot checks show the diagnostic output is BFB.
The current default value in CICE and Icepack is Tliquidus_max = -0.1, the reason for which is a mystery. This limiting (in add_new_ice) has been removed completely in the E3SM column physics, which did affect the solution substantially. (It also occurs in the FSD code, which is not yet available in E3SM.) With this PR, the limiting value can be set to anything; in particular, Tliquidus_max=0. should work. Since -0.1 is arbitrary, the official default value is set to 0. in the code but it is -0.1 in the baseline namelist (icepack_in) for backwards compatibility; this should probably be changed to 0.0 once sufficient testing of its impacts has been done in coupled systems. Addresses CICE-Consortium#385.