Update to Icepack1.3.3 release, #8f96707, Dec 9, 2022 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add saltflux_option * Add documentation for saltflux_option
Update interface documentation Remove trailing blanks in source code
…o cice-consortium/E3SM-icepack-initial-integration Update to Icepack1.3.3 release, #8f96707, Dec 9, 2022.
eclare108213
approved these changes
Dec 15, 2022
|
Thanks @apcraig. Let me know when your CICE E3SMIcepackDEV are done, and I'll merge this. I'd like to update the E3SM fork to point to this one soon, so that the saltflux changes are in there as we begin to implement and test thermo etc. |
|
CICE testing is all good, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#ec8632ff210525aa1569048ea80e7fb647b811d6. Will create a PR for CICE E3SMIcepackDEV shortly. This is ready to merge. |
|
Great, thank you. I will merge @darincomeau's PR to our E3SM fork/branch before pointing it to this new version of icepack. |
|
If you can merge this when you have a chance, then I can create the PR for CICE E3SMIcepackDEV. Thanks. |
eclare108213
merged commit a9fc4fa
into
E3SM-Project:cice-consortium/E3SM-icepack-initial-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Update to Icepack1.3.3 release, #8f96707, Dec 9, 2022.
apcraig
bit-for-bit with Consortium main #8f96707 except modal tests, https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#9d083558fefc1326bff6438015157ca53dbea956. Testing with CICE E3SMIcepackDEV looks good, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#ec8632ff210525aa1569048ea80e7fb647b811d6. log files are identical, restart files change in Tsfc at non-ice points (expected).