Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Tendencies class into separate files #159

Merged

Conversation

mwarusz
Copy link
Member

@mwarusz mwarusz commented Nov 13, 2024

This is a small PR that separates the Tendencies class from the tendency terms files into its own set of files. This was suggested in #109 (comment), but we never got around to it. Since there are no open conflicting PRs, now it is a good time to do it.

  • Testing
    • Unit tests have passed. Please provide a relevant CDash build entry for verification.

@mwarusz mwarusz requested a review from sbrus89 November 13, 2024 15:21
@mwarusz
Copy link
Member Author

mwarusz commented Nov 13, 2024

CTests pass on Chrysalis and Frontier.

@mwarusz mwarusz force-pushed the mwarusz/omega/separate-tendencies branch from 8f09e6f to 2639661 Compare November 13, 2024 15:28
@hyungyukang
Copy link

I tested this branch using the manufactured solution, which requires modifications to the Tendencies.cpp file in this PR.

I was able to run the manufactured solution test with the changes incorporated in this pull request.

Copy link

@sbrus89 sbrus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are include statements in OceanFinal.cpp and OceanInit.cpp that should be changed from TendencyTerms.h to Tendencies.h as well.

@mwarusz
Copy link
Member Author

mwarusz commented Nov 18, 2024

I think there are include statements in OceanFinal.cpp and OceanInit.cpp that should be changed from TendencyTerms.h to Tendencies.h as well.

@sbrus89 Done.

Copy link

@sbrus89 sbrus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mwarusz. This looks good.

@mark-petersen mark-petersen self-assigned this Nov 20, 2024
@mark-petersen mark-petersen merged commit b36f8cb into E3SM-Project:develop Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants