Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix State unit test failure #186

Merged

Conversation

brian-oneill
Copy link

Fixes State test failure across all platforms caused by #163

Confirmed unit tests pass on Chrysalis, Perlmutter CPU & GPU, and Frontier CPU & GPU

Resolves #183

Copy link

@philipwjones philipwjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brian-oneill . I've confirmed this fixes the State tests on various machines.
I think we also need this fix in OceanInit (line 210 for State and line 218 for Tracers)? I made the change in my local copy and everything still works. I suspect that's what is causing @xylar 's latest problems in restart testing. If you concur, can you please make that change too?

@brian-oneill
Copy link
Author

Thanks @brian-oneill . I've confirmed this fixes the State tests on various machines. I think we also need this fix in OceanInit (line 210 for State and line 218 for Tracers)? I made the change in my local copy and everything still works. I suspect that's what is causing @xylar 's latest problems in restart testing. If you concur, can you please make that change too?

Yep, certainly looks and sounds like the same issue.

Copy link

@philipwjones philipwjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks again @brian-oneill .

@philipwjones philipwjones merged commit 97f45f8 into E3SM-Project:develop Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State unit test is failing on latest develop
2 participants