Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests #194

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Improve tests #194

merged 3 commits into from
Sep 24, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Sep 22, 2024 •
edited
Loading

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@xylar xylar added ci Changes affect github actions CI clean-up Cleanup or maintenance of code that does not alter behavior or functionality labels Sep 22, 2024
@xylar xylar requested a review from altheaden September 22, 2024 11:37
@xylar xylar self-assigned this Sep 22, 2024
@xylar
Copy link
Collaborator Author

xylar commented Sep 22, 2024

Testing

I manually ran pytest tests with the mache_dev conda environment and saw that both tests passed. I also ran conda build conda and saw that the conda package build successfully (including running the tests). Finally, I confirmed that CI ran successfully.

@xylar
Copy link
Collaborator Author

xylar commented Sep 22, 2024 •
edited
Loading

@altheaden, I think this is good enough for unit tests for now. I would love to have unit tests for:

  • changing permissions
  • syncing diags
  • making a spack environment

but I think all of these are really ambitious and would be a giant time sync to get right.

altheaden
altheaden approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@altheaden altheaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me!

@xylar xylar merged commit f24de1f into E3SM-Project:main Sep 24, 2024
5 checks passed
@altheaden altheaden deleted the improve-tests branch September 24, 2024 15:12
@altheaden altheaden restored the improve-tests branch September 24, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altheaden altheaden altheaden approved these changes

Assignees

@xylar xylar

Labels
ci Changes affect github actions CI clean-up Cleanup or maintenance of code that does not alter behavior or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xylar @altheaden