Remove test groups #111
Merged
Remove test groups #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
added
clean-up
framework
NoteI do not plan to clean up the tutorial until after the reorganization (including shared steps and perhaps task-parallelism) is finished. It's too much work and too much of a moving target. The rest of the docs will also need a careful look. I have attempted to update them but haven't had time to give them a thorough read and that more thorough clean-up will also have to wait. |
xylar
force-pushed
the
remove-test-groups
branch
from
a49d21f to
41dcd0f
Compare
This was referenced Sep 4, 2023
Merged
xylar
force-pushed
the
remove-test-groups
branch
from
41dcd0f to
308ab13
Compare
cbegeman
reviewed
Sep 5, 2023
cbegeman
reviewed
Sep 5, 2023
In order to increase the flexibility in Polaris, we have removed test groups from the framework. Tasks can still be organized by a common theme in the spirit of test groups but this is no longer a requirement. The constructors for test groups have been replaced by simple functions for adding the tasks directly to each component. The subdirectories for the test groups have been prepended to the subdirectories for the tasks instead.
xylar
force-pushed
the
remove-test-groups
branch
from
308ab13 to
42de4c6
Compare
|
Thanks for the suggestions. I believe I have things cleaned up but will run the |
TestingI ran the |
|
Thanks once again, @cbegeman!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to increase the flexibility in Polaris, we have removed test groups from the framework. Tasks can still be organized by a common theme in the spirit of test groups but this is no longer a requirement.
The constructors for test groups have been replaced by simple functions for adding the tasks directly to each component. The subdirectories for the test groups have been prepended to the subdirectories for the tasks instead.
Checklist
api.md) has any new or modified class, method and/or functions listedTestingcomment in the PR documents testing used to verify the changesBased off of #110, which is based off of #112