Fix slurm handling of allocatable cores #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems like Frontier have cores that aren't allocatable. These need to be excluded from the core count that Polaris determines from slurm.
xylar
added
bug
TestingWith this fix, Polaris tasks that use more than one Frontier node run successfully, whereas they fail because they try to run on 64 cores per node (the total, rather than the allocatable number) without this fix. |
|
This needs to be tested on Chrysalis and Perlmutter to make sure it doesn't break anything there. |
|
This approach didn't work on Compy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems like Frontier have cores that aren't allocatable. These need to be excluded from the core count that Polaris determines from slurm.
Checklist
Testingcomment in the PR documents testing used to verify the changes