Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't smooth ISOMIP+ topography on base mesh #202

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jul 16, 2024

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@xylar xylar added bug Something isn't working ocean Related to ocean tests or analysis labels Jul 16, 2024
@xylar xylar self-assigned this Jul 16, 2024
@xylar
Copy link
Collaborator Author

xylar commented Jul 16, 2024

Testing

I tried 3 levels of smoothing (expansion factor 1, 2, and 4) as part of work to add mbtempest support. I discovered that a change I made in #201 wasn't good. We don't want to smooth the topography before culling because it expands the ocean domain in a way we don't want.

With this change, a smoothing factor of 1 (no smoothing) and 2 lead to the same ocean domain size, as expected. I tested this with 4km, planar Ocean0 on Chrysalis.

@xylar xylar merged commit b31ab2d into E3SM-Project:main Jul 16, 2024
4 checks passed
@xylar xylar deleted the fix-isomip-plus-culling branch July 16, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocean Related to ocean tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant