Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating mapping files with mbtempest #203

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jul 17, 2024

This merge adds support for creating mapping files with mbtempest in addition to ESMF_RegridWeightGen. I have added moab with tempest-remap as a conda dependency.

Because mbtempest creates mapping files in 2 steps (first creating intersections and then creating the mapping file), I have modified the args attribute of Step to be a list of lists, allowing multiple commands. Each command is required to take the same parallel resources, which is fine for mbtempest.

I have added a new config file mapping.cfg with a [mapping] section and a map_tool config option (either esmf or moab). I have made moab the default.

Finally, I have updated the isomip_plus tests include the new mapping config.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes

@xylar xylar self-assigned this Jul 17, 2024
@xylar xylar added enhancement New feature or request framework Changes relating to the polaris framework as opposed to individual tests or analysis ocean Related to ocean tests or analysis labels Jul 17, 2024
@xylar
Copy link
Collaborator Author

xylar commented Jul 17, 2024

Testing

I successfully ran the ISOMIP+ Ocean0 planar, z-star test case at 4km resolution on Chrysalis. I ran with the default expansion factor of 2.0 as well as 1.0 and 4.0, verifying visually in ParaView that the resulting topography was smoother in proportion to the factor, as expected.

@xylar xylar merged commit 3fbb789 into E3SM-Project:main Jul 17, 2024
4 checks passed
@xylar xylar deleted the add-mbtempest branch July 17, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request framework Changes relating to the polaris framework as opposed to individual tests or analysis ocean Related to ocean tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant