Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gpus-per-node to job scripts and resources #207

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Add gpus-per-node to job scripts and resources #207

merged 3 commits into from
Jul 22, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jul 22, 2024 •
edited
Loading

Checklist

  • API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
  • Testing comment in the PR documents testing used to verify the changes

@xylar xylar requested a review from altheaden July 22, 2024 17:00
@xylar xylar self-assigned this Jul 22, 2024
@xylar
Copy link
Collaborator Author

xylar commented Jul 22, 2024

This is probably needed before #204. It probably shouldn't be included in that PR so things are cleaner, but it also can't really be tested without the new version of mache in that PR.

@xylar xylar marked this pull request as ready for review July 22, 2024 17:48
@xylar
Copy link
Collaborator Author

xylar commented Jul 22, 2024 •
edited by altheaden
Loading

Testing

In combination with #204, @altheaden tested this by running the Omega CTests on Perlmutter-GPU with gnugpu and nvidiagpu.

@xylar
Copy link
Collaborator Author

xylar commented Jul 22, 2024

@altheaden, can you approve this based on your testing?

@xylar xylar added enhancement New feature or request framework Changes relating to the polaris framework as opposed to individual tests or analysis utility Utility script(s) in the utils directory labels Jul 22, 2024
altheaden
altheaden approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@altheaden altheaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This worked for me on pm-gpu with gnugpu and nvidiagpu. Without these changes, both tests were failing.

@xylar xylar assigned altheaden and unassigned xylar Jul 22, 2024
@altheaden altheaden merged commit 937c6eb into E3SM-Project:main Jul 22, 2024
4 checks passed
@xylar xylar deleted the add-gpus-flag-to-job-scripts branch July 22, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altheaden altheaden altheaden approved these changes

Assignees

@altheaden altheaden

Labels
enhancement New feature or request framework Changes relating to the polaris framework as opposed to individual tests or analysis utility Utility script(s) in the utils directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xylar @altheaden