-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup configure_polaris_envs.py
and deploy/shared.py
#209
Cleanup configure_polaris_envs.py
and deploy/shared.py
#209
Conversation
TestingI tested this branch by creating a new polaris environment. Everything, as far as I can tell, went smoothly. |
configure_polaris_envs.py
and deploy/shared.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@altheaden, this looks excellent apart from one small thing to fix up. Once that's fixed, I'll test deployment both with the mache package from conda-forge and the local_mache
cloned from a fork and branch.
7bb9fd2
to
2a758d7
Compare
@altheaden, other than my comment on the comment (how meta!) above, everything looks good by inspection. I'll do the tests I said it'd do and approve unless I run into any trouble. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to create a polaris conda environment and activation script both with and without the --mache_fork/--mache_branch
options. I don't think any further testing is needed for this PR.
Thanks for working on this, @altheaden!
@xylar sounds great! I'll update that comment and then merge. |
Co-authored-by: Xylar Asay-Davis <xylarstorm@gmail.com>
This PR includes some general cleanup that I did in
configure_polaris_envs.py
anddeploy/bootstrap.py
, as well as a slight change to the commands which install mache. The cleanup I did consisted of the following:FileNotFound
error instead of a more generalOSError
)makedirs()
which has a built-inFileExistsError
check)The installation of mache now calls upon a new file,
deploy/spec-bootstrap.txt
instead of listing mache's dependencies directly in the configure script. This change is both to make the script more modular and to make updating this list easier.Checklist
Testing
comment in the PR documents testing used to verify the changes