Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manufactured solution viz step #250

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Nov 29, 2024

This merge fixes the manufactured solution viz step following #236 to account for new directory names and to include the time step as well as the resolution in plot panels.

A few other small pieces of clean up are also included for convenience.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

Fixes #248

@xylar xylar added bug Something isn't working ocean Related to ocean tests or analysis labels Nov 29, 2024
@xylar xylar requested a review from cbegeman November 29, 2024 12:13
@xylar xylar self-assigned this Nov 29, 2024
@xylar
Copy link
Collaborator Author

xylar commented Nov 29, 2024

Testing

I was able to run the manufactured solution convergence_both test with MPAS-Ocean on Chrysalis. (The analysis step fails as usual because the tolerance is not met.) The result of the viz step is:
comparison
Note that the time step as well as the resolution are plotted on the left.

@xylar xylar mentioned this pull request Nov 29, 2024
1 task
Copy link
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @xylar! This looks great. Approving by visual inspection

@xylar
Copy link
Collaborator Author

xylar commented Dec 2, 2024

Thanks @cbegeman!

@xylar xylar merged commit e1ad8af into E3SM-Project:main Dec 2, 2024
5 checks passed
@xylar xylar deleted the fix-manufactured-solution-viz branch December 2, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocean Related to ocean tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manufactured solution viz step needs to be updated to use correct forward run paths
2 participants