Logger cleanup and clarification #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this with the pr suite against a baseline. The logging changed as expected and the baseline verification was successful. |
|
I also built the documentation locally and it looks as expected. |
There are a lot of loggers at play, so this change made them more readable when they always write to stdout.
Just renamed these older references, and changed the output in the docs as well.
This is the behavior we expect when checking to see if the step has a log filename later on, such as in `SphericalBaseStep`.
|
Oops - I had to rebase, but now it's ready for review :) |
xylar
reviewed
Jun 1, 2023
|
@xylar I fixed the formatting. |
Fix string formatting. Co-authored-by: Xylar Asay-Davis <xylarstorm@gmail.com>
xylar
approved these changes
Jun 1, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a few things concerning loggers. Some loggers in
run/serial.pyhave been renamed for better code readability, indicating when they are logging to stdout vs an internal file. Thelog_filenameattribute inStephas been explicitly set to None by default, as opposed to an empty string. And in general, some "compass" wording needed to be changed to "polaris".Checklist
Testingcomment in the PR documents testing used to verify the changes