Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate creating parallel command and running command #78

Merged
merged 1 commit into from
Jun 3, 2023

Conversation

altheaden
Copy link
Collaborator

Creating the command is now a process that can be called without running the command, for use when we wish to run the command elsewhere.

Checklist

  • API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
  • Testing comment in the PR documents testing used to verify the changes

@altheaden
Copy link
Collaborator Author

I tested this branch with the cosine bell suite, against a baseline, and everything ran as expected.

@altheaden altheaden requested a review from xylar June 2, 2023 21:37
@altheaden altheaden added the framework Changes relating to the polaris framework as opposed to individual tests or analysis label Jun 2, 2023
@xylar
Copy link
Collaborator

xylar commented Jun 2, 2023

@altheaden, this is great! I'll test this now. Could you add a line just above or below this one:
https://github.com/E3SM-Project/polaris/blob/main/docs/developers_guide/api.md?plain=1#L302
that refers to the new function? That way, it will show up in the automatically generated docs.

@altheaden
Copy link
Collaborator Author

@xylar Sure, I noticed that there are some other un-updated functions in that file (e.g. get_available_cores_and_nodes instead of get_available_parallel_resources, should I update all of the functions for polaris.parallel.py?

@xylar
Copy link
Collaborator

xylar commented Jun 2, 2023

@altheaden, yes, please do!

Creating the command is now a process that can be called without running
the command, for use when we wish to run the command separately.
@altheaden altheaden force-pushed the refactor-run-command branch from 8dce9b3 to c9e239e Compare June 3, 2023 00:23
@altheaden
Copy link
Collaborator Author

@xylar done, let me know if there is anything else I need to do!

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the pr suite with this branch, comparing against a baseline of the current main and everything passed. Thanks @altheaden!

@xylar xylar merged commit dcd370e into E3SM-Project:main Jun 3, 2023
@xylar xylar self-assigned this Jun 3, 2023
@altheaden altheaden deleted the refactor-run-command branch June 5, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework Changes relating to the polaris framework as opposed to individual tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants