Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull out common setup between run procedures #84

Merged
merged 2 commits into from
Jun 10, 2023

Conversation

altheaden
Copy link
Collaborator

@altheaden altheaden commented Jun 9, 2023

There is a little bit of setup that is common to setting up a suite, test case, or step, and we can modularize it better. This will be further utilized during development of the parallel counterpart to run.serial.

Checklist

  • API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
  • Testing comment in the PR documents testing used to verify the changes

There is a little bit of setup that is common to setting up a suite,
test case, or step, and we can modularize it better.
@altheaden altheaden added framework Changes relating to the polaris framework as opposed to individual tests or analysis in progress This PR is not ready for review or merging labels Jun 9, 2023
@altheaden
Copy link
Collaborator Author

Testing: I tested this using the PR suite against a baseline and it ran successfully.

@altheaden
Copy link
Collaborator Author

I just updated the API documentation and now this PR is ready for review.

@altheaden altheaden marked this pull request as ready for review June 9, 2023 18:09
@altheaden altheaden requested a review from xylar June 9, 2023 18:09
@altheaden altheaden added clean-up and removed in progress This PR is not ready for review or merging labels Jun 9, 2023
@xylar
Copy link
Collaborator

xylar commented Jun 10, 2023

@altheaden, this looks great! I'm just running a quick test now and then I'll merge if all goes as planned.

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first test, I forgot to rebuild MPAS-Ocean following #62 and that test failed, revealing the problem I reported in #85.

After updating the submodule and rebuilding MPAS-Ocean, the pr suite ran successfully!

@xylar xylar merged commit f8c63e9 into E3SM-Project:main Jun 10, 2023
@xylar xylar deleted the extract-common-run-setup branch June 10, 2023 02:05
@xylar
Copy link
Collaborator

xylar commented Jun 10, 2023

Thanks for doing this work, @altheaden!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up framework Changes relating to the polaris framework as opposed to individual tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants