Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dependencies with smaller time increments #603

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Handle dependencies with smaller time increments #603

merged 2 commits into from
Jul 23, 2024

Conversation

forsyth2
Copy link
Collaborator

Handle dependencies with smaller time increments. Resolves #599

@forsyth2 forsyth2 self-assigned this Jun 17, 2024
@forsyth2 forsyth2 force-pushed the issue-599 branch 2 times, most recently from 139c4d2 to 4830a8c Compare July 9, 2024 19:45
@forsyth2
Copy link
Collaborator Author

forsyth2 commented Jul 12, 2024

In the latest implementation:

$ cd /lcrc/group/e3sm/ac.forsyth2/zppy_test_complete_run_output/test_599-post-600v3/v2.LR.historical_0201/post/scripts
e3sm_diags_atm_monthly_180x360_aave_model_vs_obs_1850-1851.status:WAITING 548775
e3sm_diags_atm_monthly_180x360_aave_model_vs_obs_1850-1853.status:WAITING 548777
e3sm_diags_atm_monthly_180x360_aave_model_vs_obs_1852-1853.status:WAITING 548776
e3sm_diags_atm_monthly_180x360_aave_mvm_model_vs_model_1852-1853_vs_1850-1851.status:WAITING 548782
e3sm_diags_lnd_monthly_mvm_lnd_model_vs_model_1850-1851_vs_1850-1851.status:WAITING 548783
global_time_series_1850-1860.status:WAITING 548786
ilamb_1850-1853.status:WAITING 548787
mpas_analysis_ts_1850-1854_climo_1850-1854.status:WAITING 548784
mpas_analysis_ts_1850-1860_climo_1855-1860.status:WAITING 548785

This pull request doesn't even touch mpas_analysis.py so it is unclear why those tasks are affected.

@forsyth2 forsyth2 force-pushed the issue-599 branch 3 times, most recently from 9597117 to d570987 Compare July 19, 2024 22:49
@forsyth2
Copy link
Collaborator Author

Test of min_case_add_dependencies shows 2 errors:

1st, global time series is looking for the wrong dependency:

global_time_series_1985-1994
...skipping because of dependency status file missing
   /lcrc/group/e3sm/ac.forsyth2/zppy_min_case_add_dependencies_output/unique_id/v3.LR.historical_0051/post/scripts/ts_atm_monthly_glb_1985-1994-0010.status

We want two 5-year increment ts files...

2nd, e3sm_diags_atm_monthly_180x360_aave_model_vs_obs_1985-1994 is failing: ref_start_yr = doesn't get defined in e3sm.py.

@forsyth2 forsyth2 force-pushed the issue-599 branch 2 times, most recently from 6e16d46 to bf93f52 Compare July 23, 2024 01:47
@forsyth2
Copy link
Collaborator Author

Tested with min_case_add_dependencies

@forsyth2 forsyth2 marked this pull request as ready for review July 23, 2024 01:48
@forsyth2 forsyth2 merged commit 4d55865 into main Jul 23, 2024
4 checks passed
@forsyth2 forsyth2 deleted the issue-599 branch July 23, 2024 01:57
@forsyth2 forsyth2 mentioned this pull request Dec 17, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant