Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MQL4 syntax for ATR_MA_Trend.mq4 #8

Open
kenorb opened this issue May 29, 2023 · 1 comment · Fixed by #17
Open

Fix MQL4 syntax for ATR_MA_Trend.mq4 #8

kenorb opened this issue May 29, 2023 · 1 comment · Fixed by #17
Assignees
@kenorb @nseam
Labels
enhancement New feature or request

Comments

@kenorb
Copy link
Member

kenorb commented May 29, 2023 •
edited
Loading

Rename Misc/ATR_MA_Trend.mq4.todo to .mq4 and check the syntax for MQL4. It's used by ATR_MA_Trend strategy.

Est. 1d
@kenorb kenorb added the enhancement New feature or request label May 29, 2023
@kenorb kenorb added this to EA v3.000 Aug 26, 2023
@kenorb kenorb moved this to In Progress in EA v3.000 Nov 22, 2023
nseam added a commit to nseam/EA31337-classes that referenced this issue Nov 22, 2023
@nseam
Refs EA31337/EA31337-indicators-other#8. Added underscores to some fu…
30ed4a8 
…nction parameter names to prevent conflicts with global variables.
nseam added a commit to nseam/EA31337-classes that referenced this issue Nov 22, 2023
@nseam
Refs EA31337/EA31337-indicators-other#8. Added IndicatorLegacy.h file…
0ddfa58 
… to allow using MQL5 versions of iNAME() indicators like iMA(), iRSI() in MQL4. Used to run MQL5 indicators in MQL4.
nseam added a commit to nseam/EA31337-indicators-other that referenced this issue Nov 22, 2023
@nseam
Refs EA31337#8. ATR_MA_Trend now uses IndicatorLegacy.h file to allow…
be542c4 
… using MQL5 versions of iNAME() indicators like iMA(), iRSI() in MQL4. We use it to run MQL5 indicator in MQL4.
kenorb added a commit that referenced this issue Nov 22, 2023
@kenorb
Merge pull request #17 from nseam/master
43b5a2e 
Refs #8. ATR_MA_Trend now uses IndicatorLegacy
kenorb added a commit to EA31337/EA31337-classes that referenced this issue Apr 23, 2024
@kenorb
Merge branch 'v3.001-dev-new' into v3.001-dev
1fc4f06 
* v3.001-dev-new:
  Fixes new lines [end-of-file-fixer]
  GHA: Compile: Support for workflow calls
  GHA: Compile: Skips clean-up by default
  Adds vscode's extensions for devcontainer
  Adds initial config for .devcontainer/devcontainer.json
  GHA: Fixes compilation workflows
  Refs EA31337/Strategy-TDI#1. MA-targeted changes regarding input MA method and iMAOnArray implementation which input is now changed to native array (from ValueStorage).
  Refs EA31337/EA31337-indicators-other#8. Added IndicatorLegacy.h file to allow using MQL5 versions of iNAME() indicators like iMA(), iRSI() in MQL4. Used to run MQL5 indicators in MQL4.
  Refs EA31337/EA31337-indicators-other#8. Added underscores to some function parameter names  to prevent conflicts with global variables.
  Refs #11. Renamed "index" variable names into "_idx" to prevent conflicts with global variables. Also added new CreateObject() specialization to Draw.mqh. Added #ifdef to Terminal.define.h to prevent redefinition of defines.
  Indi_Fractals: Fixes code typo
  Final fix for orders are opened instead of being closed for both MT4 and MT5 (fixes GH-707)
  Fixes C++ error: no matching function for call
kenorb added a commit to EA31337/EA31337-classes that referenced this issue Apr 24, 2024
@kenorb
Merge branch 'v3.001-dev' into v3.002-dev
52c8fcc 
* v3.001-dev:
  GHA: Compile: Fixes uploading artifacts after compilation
  GHA: Compile: Ignores compiling platform files
  Fixing CompileTest
  Fixes compilation errors on build 4275
  GHA: Test: Includes compile workflow
  Fixes new lines [end-of-file-fixer]
  GHA: Compile: Support for workflow calls
  GHA: Compile: Skips clean-up by default
  Adds vscode's extensions for devcontainer
  Adds initial config for .devcontainer/devcontainer.json
  GHA: Fixes compilation workflows
  Refs EA31337/Strategy-TDI#1. MA-targeted changes regarding input MA method and iMAOnArray implementation which input is now changed to native array (from ValueStorage).
  Refs EA31337/EA31337-indicators-other#8. Added IndicatorLegacy.h file to allow using MQL5 versions of iNAME() indicators like iMA(), iRSI() in MQL4. Used to run MQL5 indicators in MQL4.
  Refs EA31337/EA31337-indicators-other#8. Added underscores to some function parameter names  to prevent conflicts with global variables.
  Refs #11. Renamed "index" variable names into "_idx" to prevent conflicts with global variables. Also added new CreateObject() specialization to Draw.mqh. Added #ifdef to Terminal.define.h to prevent redefinition of defines.
  Indi_Fractals: Fixes code typo
  Final fix for orders are opened instead of being closed for both MT4 and MT5 (fixes GH-707)
  Fixes C++ error: no matching function for call
kenorb added a commit that referenced this issue Aug 20, 2024
@kenorb
Merge remote-tracking branch 'origin/master' into dev
9d5d774 
* origin/master:
  Refs #8. ATR_MA_Trend now uses IndicatorLegacy.h file to allow using MQL5 versions of iNAME() indicators like iMA(), iRSI() in MQL4. We use it to run MQL5 indicator in MQL4.
  Refs #11. Fixed warnings. "Compile" GitHub action will now use EA31337-classes v3.000-dev.
  Refs #11. MQL5 compatible version of SuperSlope oscillator. Unsure if it works correctly.
kenorb added a commit that referenced this issue Aug 20, 2024
@kenorb
Merge remote-tracking branch 'origin/master' into dev
87b50d3 
* origin/master:
  Refs #8. ATR_MA_Trend now uses IndicatorLegacy.h file to allow using MQL5 versions of iNAME() indicators like iMA(), iRSI() in MQL4. We use it to run MQL5 indicator in MQL4.
  Refs #11. Fixed warnings. "Compile" GitHub action will now use EA31337-classes v3.000-dev.
  Refs #11. MQL5 compatible version of SuperSlope oscillator. Unsure if it works correctly.
@kenorb kenorb added this to EA v3.001 Aug 24, 2024
@kenorb kenorb removed this from EA v3.000 Aug 24, 2024
@kenorb kenorb mentioned this issue Sep 23, 2024
Merged
@kenorb
Copy link
Member Author

kenorb commented Sep 23, 2024

Fixed in GH-17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenorb kenorb

@nseam nseam

Labels
enhancement New feature or request
Projects
EA v3.001
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refs #8. ATR_MA_Trend now uses IndicatorLegacy nseam/EA31337-indicators-other
2 participants
@kenorb @nseam