Kba/minor bugfixes #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…- removes some redundant code
…sync functionality
…fixes a bug on multilinetext where focus on inputcontrol did not set the question to active
…ame to provider anyway so did not make sense to have it
pksorensen
approved these changes
May 31, 2024
| @@ -2,6 +2,7 @@ | |||
| import React from 'react'; | |||
| import { useQuickForm } from "../state/QuickFormContext"; | |||
| import { Ending, Submit, Intro, SlideRenderer } from "./index"; | |||
| import "./question/input-types/index"; | |||
There was a problem hiding this comment.
Did we not remove this some point so its not quickform itself that loads input components? the project should load the inputs?
There was a problem hiding this comment.
We left multi and the 3 baseinputcomponents behind so quickform would have some sort of functionality without registering. Very "skinny" version.
There was a problem hiding this comment.
We could do a ./core, ./input-controls package and put them all there though.
…ground to use them from components folder instead
|
🎉 This PR is included in version @eavfw/quickform-core-v1.1.0-vnext.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @eavfw/quickform-designer-v1.0.1-vnext.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr does the following: