Hotfix/expired tokens #369
Conversation
| @@ -244,6 +244,11 @@ async function fetchData( | |||
| rawResponse: response, | |||
| }); | |||
| } catch (error) { | |||
| if (error.response.status === 401) { | |||
There was a problem hiding this comment.
Is the user then going to be presented with the login automatically again?
In that case, a message would be useful such as "Session expired, please login again".
There was a problem hiding this comment.
There was a problem hiding this comment.
I can't see the screenshot, the upload doesn't seem to have worked
There was a problem hiding this comment.
Hi @mberacochea let me know if you can see the screenshot now
There was a problem hiding this comment.
yeah, I can see the message now. IMO a VF info banner would be better, they are less obstructive.
There was a problem hiding this comment.
thanks @mberacochea I've added the banner as suggested.
made a couple more changes to make the login form use a primary button and a loading spinner
There was a problem hiding this comment.
Brilliant - thank you @MGS-sails ! One small query inline about possible race condition, otherwise happy to merge.
src/pages/Login/index.tsx
Outdated
| @@ -82,16 +85,21 @@ const Login: React.FC = () => { | |||
| setAuthToken(accessToken) as unknown as void; | |||
| setUsername(''); | |||
| setPassword(''); | |||
| if (localStorage.getItem('mgnify.sessionExpired')) { | |||
| localStorage.removeItem('mgnify.sessionExpired'); | |||
There was a problem hiding this comment.
do we need to await this to avoid some race condition?
There was a problem hiding this comment.
thanks @SandyRogers actually I had meant to remove this part of the code, just pushed another commit to do that now.
I came to the conclusion that this part is not necessary. Trying to do this kind of opened a small can of worms.
The users can always just dismiss the banner. So I thought it may not be necessary to do this at this point in time
No description provided.