Various minor fixes #156
Merged
Various minor fixes #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hqcasanova
commented
Jun 6, 2018
hqcasanova
commented
- Bumps up the version of several non-plugin NPM packages (one of them being Angular) to partially resolve the vulnerabilities reported by Github: only the one regarding Handlebars. Resolving them entirely entails updating Angular-CLI to 6, which is only supported by Angular 5. Note that Angular-CLI's team points out that the offending package (Hoek) is not used by their software. So migration to v5 can be carried out in subsequent branch, ideally after multiple direct upload has been implemented and the plugin dependencies updated.
- Fixes responsive issues with the re-activation and password-reset screens.
- Fixes unit tests.
added 3 commits
June 6, 2018 11:55
…ities. Minor UX fixes to login screens.
… fix/hoek_handlebars_vulnerabilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.