EVA-3664 Reserve new block - create new transaction for every retry #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitin-ebi
force-pushed
the
new-transaction-for-every-retry
branch
from
ce2569d to
a8ec14c
Compare
tcezard
approved these changes
Oct 9, 2024
tcezard
reviewed
Oct 9, 2024
| @@ -91,7 +92,7 @@ public void save(ContiguousIdBlock block) { | |||
| entityManager.flush(); | |||
| } | |||
|
|
|||
| @Transactional(isolation = Isolation.SERIALIZABLE) | |||
| @Transactional(isolation = Isolation.SERIALIZABLE, propagation = Propagation.REQUIRES_NEW) | |||
There was a problem hiding this comment.
I tried to read up on how this propagation works but I feel it would be good to get your explanation.
apriltuesday
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.