EVA-3699 EVA json to ENA Json Converter #236
Conversation
| ena_projects_json_obj = [ | ||
| self._create_ena_project_json_obj(self.eva_json_data['project'], self.submission_id)] | ||
| else: | ||
| # TODO: if existing project - should the projects field in json be empty or should not exist at all |
There was a problem hiding this comment.
Is there a dev endpoint from ENA we can use to test it out?
There was a problem hiding this comment.
There is a test endpoint we can use but in this case I think the project should be absent.
|
|
||
| return self.output_ena_json_file | ||
|
|
||
| def create_ena_submission(self): |
There was a problem hiding this comment.
Not sure why there are 2 of this method?
| return {} | ||
|
|
||
| def get_samples_refs(samples): | ||
| # TODO: sample id ?? |
There was a problem hiding this comment.
Also not sure about this as it's not in the CLI template, maybe should use sampleInVCF?
There was a problem hiding this comment.
In the current analysis object in XML, we're using accession and label, I'm actually not sure that the label is required. We should double check first that it is.
There was a problem hiding this comment.
json example contains accession and alias.Nothing explicitly mentioned in the documents sent by dipayan.. will need to check further
No description provided.