Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install plugin form admin plugin management #2537

Closed
wants to merge 7 commits into from
Closed

install plugin form admin plugin management #2537

wants to merge 7 commits into from

Conversation

hoand-vn
Copy link
Contributor

@hoand-vn hoand-vn commented Oct 3, 2017 •
edited
Loading

Overview

  • Admin can click to install plugin from list
  • After install, status of plugin will be change to installed

Policy

  • Plugin will be get & install from Repository via composer command
  • If the plugin depend on other plugins, automatic install dependence plugins
  • Use S3 to get plugin source
  • Show message success or fail at admin management screen

Appendix

Test

  • on local without https
  • Birthday plugin only depend on plugin-installer plugin
  • Still not more test plugin A depend on B, B depend on C

Discussion

  • Need https to remove temporary config in composer.json ( "config": { "secure-http":false, } )
  • Still not doing un-install pugin
  • Plugin Birthday need config mail server to work well

@hoand-vn hoand-vn mentioned this pull request Oct 5, 2017
Merged
@kiy0taka kiy0taka added this to the 3.1.0 milestone Oct 7, 2017
@ryo-endo
Copy link
Contributor

#2583でまとめて取り込まれたのでCLOSEします。

@ryo-endo ryo-endo closed this Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
experimental
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hoand-vn @ryo-endo @kiy0taka @Yangsin @lqdung-lockon