Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eccube/feature/fix php74 deprecated type declarations #6287

Draft
wants to merge 29 commits into
base: 4.3
Choose a base branch
from

fix Error: Method Eccube\Entity\AbstractEntity::offsetGet() should re…

d95b3fa
Select commit
Loading
Failed to load commit list.
Draft

Eccube/feature/fix php74 deprecated type declarations #6287

fix Error: Method Eccube\Entity\AbstractEntity::offsetGet() should re…
d95b3fa
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 20, 2024 in 0s

78.23% (-4.46%) compared to 8dfeee5

View this Pull Request on Codecov

78.23% (-4.46%) compared to 8dfeee5

Details

Codecov Report

Attention: Patch coverage is 88.70523% with 41 lines in your changes missing coverage. Please review.

Project coverage is 78.23%. Comparing base (8dfeee5) to head (d95b3fa).
Report is 43 commits behind head on 4.3.

Files with missing lines Patch % Lines
src/Eccube/Session/Session.php 22.22% 7 Missing ⚠️
src/Eccube/Form/Type/Master/PageMaxType.php 0.00% 4 Missing ⚠️
...rc/Eccube/Form/Type/Admin/PluginManagementType.php 0.00% 3 Missing ⚠️
src/Eccube/Form/Type/Admin/SearchPluginApiType.php 0.00% 3 Missing ⚠️
src/Eccube/Form/Type/Admin/TagType.php 0.00% 3 Missing ⚠️
src/Eccube/Form/Type/ShoppingMultipleType.php 0.00% 3 Missing ⚠️
src/Eccube/Twig/Template.php 0.00% 3 Missing ⚠️
src/Eccube/Form/Type/Admin/PageType.php 0.00% 2 Missing ⚠️
.../Eccube/Form/Type/Admin/PluginLocalInstallType.php 0.00% 2 Missing ⚠️
src/Eccube/Form/Type/Admin/TwoFactorAuthType.php 0.00% 2 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              4.3    #6287      +/-   ##
==========================================
- Coverage   82.69%   78.23%   -4.46%     
==========================================
  Files         480      480              
  Lines       26465    26527      +62     
==========================================
- Hits        21885    20754    -1131     
- Misses       4580     5773    +1193

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

View more details on Codecov