Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit 9.6 へのバージョンアップ #1022

Merged
merged 13 commits into from
Oct 9, 2024

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Oct 4, 2024

Fixes #1020

  • Warning の解消
  • カバレッジの確認

@nanasess
Copy link
Contributor Author

nanasess commented Oct 4, 2024

テストのエラーは #1018 で解消予定

```
Your lock file does not contain a compatible set of packages. Please run composer update.

  Problem 1
    - psr/cache is locked to version 1.0.1 and an update of this package was not requested.
    - You can only install one version of a package, so only one of
    these can be installed: psr/cache[1.0.1].
```
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.66%. Comparing base (6c22132) to head (efe6ab3).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
- Coverage   56.23%   51.66%   -4.57%     
==========================================
  Files          75       80       +5     
  Lines        9046    10155    +1109     
==========================================
+ Hits         5087     5247     +160     
- Misses       3959     4908     +949     
Flag Coverage Δ
tests 51.66% <ø> (-4.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess marked this pull request as ready for review October 9, 2024 17:14
@nanasess nanasess merged commit 5717abe into EC-CUBE:master Oct 9, 2024
90 of 91 checks passed
@nanasess nanasess deleted the bump-phpunit branch October 9, 2024 17:15
@nanasess
Copy link
Contributor Author

nanasess commented Oct 9, 2024

php-cs-fixer を最新にすると影響が大きいため、別 PR で対応します

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHPUnit のバージョンアップ
2 participants