3.0.18に合わせたcodeceptionの修正 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
May 14, 2019 10:31
11 tasks
|
申し訳ありません、修正します。 |
kiy0taka
suggested changes
May 15, 2019
| @@ -7,42 +7,42 @@ services: | |||
| - docker | |||
|
|
|||
| env: | |||
| ## Firefox, PostgreSQL | |||
There was a problem hiding this comment.
すべてchromeになってしまっているので、firefoxはallow_failuresで残しておいて下さい。
tests/acceptance/EA04OrderCest.php
Outdated
|
|
||
| codecept_debug($I->grabTextFrom('#template-change')); | ||
|
|
||
| $I->selectOption(['id' => 'template-change'], 'ご注文ありがとうございます'); |
There was a problem hiding this comment.
selectOption の第二引数は値だけだと選択するのに時間がかかるので ['id' => 'value'] の形でお願いします。
tests/acceptance/EA04OrderCest.php
Outdated
| @@ -257,7 +260,7 @@ public function order_一括メール通知(\AcceptanceTester $I) | |||
| ->一覧_全選択() | |||
| ->メール一括通知(); | |||
|
|
|||
| $I->selectOption(['id' => 'template-change'], ['1' => '注文受付メール']); | |||
| $I->selectOption(['id' => 'template-change'], 'ご注文ありがとうございます'); | |||
There was a problem hiding this comment.
selectOption の第二引数は値だけだと選択するのに時間がかかるので ['id' => 'value'] の形でお願いします。
kiy0taka
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.