-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save argument does not get overwritten by command line arg #41
Comments
Default_utils.py specifies ‘save_path’ as a variable for this purpose.
I believe we decided against ‘save’ as a keyword because its intent is ambiguous (is it a boolean ‘save = True’, etc)
Jamaludin Mohd Yusof, PhD
Future Architectures and Applications
CCS-7 Applied Computer Science Group
Phone: (505) 665-2870
Fax : (505) 665-4939
Email: jamal@lanl.gov<mailto:jamal@lanl.gov>
On Mar 19, 2019, at 11:14 AM, Thomas Brettin <notifications@github.com<mailto:notifications@github.com>> wrote:
save is defined and assigned a value in uno_default_params.txt
when --save is specified on the command line, it does not override the value in the default_params.txt file
when i hack default_utils.py and add
parser.add_argument('--save', ...
it seems to work.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#41>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAstHw7XvZP8rVjIuwinEFu-gCmpufiwks5vYRsEgaJpZM4b8ref>.
|
We also have output_dir which is used in some benchmarks. I believe the intent of this was to be used with the experiment directories (EXP00/RUN00 etc) to standardize paths when using supervisor?
Jamaludin Mohd Yusof, PhD
Future Architectures and Applications
CCS-7 Applied Computer Science Group
Phone: (505) 665-2870
Fax : (505) 665-4939
Email: jamal@lanl.gov<mailto:jamal@lanl.gov>
On Mar 19, 2019, at 11:20 AM, Mohd-Yusof, Jamal <jamal@lanl.gov<mailto:jamal@lanl.gov>> wrote:
Default_utils.py specifies ‘save_path’ as a variable for this purpose.
I believe we decided against ‘save’ as a keyword because its intent is ambiguous (is it a boolean ‘save = True’, etc)
Jamaludin Mohd Yusof, PhD
Future Architectures and Applications
CCS-7 Applied Computer Science Group
Phone: (505) 665-2870
Fax : (505) 665-4939
Email: jamal@lanl.gov<mailto:jamal@lanl.gov>
On Mar 19, 2019, at 11:14 AM, Thomas Brettin <notifications@github.com<mailto:notifications@github.com>> wrote:
save is defined and assigned a value in uno_default_params.txt
when --save is specified on the command line, it does not override the value in the default_params.txt file
when i hack default_utils.py and add
parser.add_argument('--save', ...
it seems to work.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#41>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAstHw7XvZP8rVjIuwinEFu-gCmpufiwks5vYRsEgaJpZM4b8ref>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
save is defined and assigned a value in uno_default_params.txt
when --save is specified on the command line, it does not override the value in the default_params.txt file
when i hack default_utils.py and add
parser.add_argument('--save', ...
it seems to work.
The text was updated successfully, but these errors were encountered: