Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ckpt module to write stats only #26

Open
j-woz opened this issue May 25, 2023 · 8 comments
Open

Allow ckpt module to write stats only #26

j-woz opened this issue May 25, 2023 · 8 comments
Assignees

Comments

@j-woz
Copy link

j-woz commented May 25, 2023

For IMPROVE results

@j-woz j-woz self-assigned this May 25, 2023
@jmohdyusof
Copy link
Collaborator

Does this mean write stats every timestep regardless of ckpt settings? This seems to make sense to me

j-woz added a commit to j-woz/candle_lib that referenced this issue May 25, 2023
@j-woz
Copy link
Author

j-woz commented May 25, 2023

The user can get that with ckpt_save_interval=1 and ckpt_save_weights_file=False

@j-woz
Copy link
Author

j-woz commented May 25, 2023

This works as of 0fb15f7 with no application changes

@jmohdyusof
Copy link
Collaborator

What happens if I want to have the stats written and then have a usable best checkpoint? Won't ckpt_save_weights_file=False make the ckpt useless?

@j-woz
Copy link
Author

j-woz commented May 25, 2023

That isn't supported here but I can do that next

@jmohdyusof
Copy link
Collaborator

I think the stats output should be on every timestep by default.

@j-woz
Copy link
Author

j-woz commented May 25, 2023

Yes, I can see the use for that

@jmohdyusof
Copy link
Collaborator

jmohdyusof commented May 25, 2023

I think the intent is (was?) to use this for the standard metric output. Maybe I am misremembering, but if I am correct then the stats_every_epoch makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants