-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Particle Buffer for Backtransformed Diagnostics #1898
Merged
ax3l
merged 85 commits into
ECP-WarpX:development
from
RevathiJambunathan:AddParticlesForBTD
Jan 7, 2022
Merged
Changes from 1 commit
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
c35c006
move BTD call before Redistribute
RevathiJambunathan dedffbb
define particle buffer, BTD particle functor, particle filter
RevathiJambunathan 471ab5b
select particles on the slice
RevathiJambunathan b763098
add particle functors
RevathiJambunathan fd325fe
add Lorentz Transform
RevathiJambunathan 43ed4f8
fix conflict
RevathiJambunathan b329b76
add call to loretnz operator
RevathiJambunathan f1d5beb
storing Particles in buffer
RevathiJambunathan db5733d
This is WIP. Added particle buffers, filled them, sent them for flush…
RevathiJambunathan ac24482
trailing endif after rebase
RevathiJambunathan 49423b0
adding print statements and not flushing particles in OPENPMD if nump…
RevathiJambunathan 68e5add
last timestep flush is ensured at the end of evolve loop
RevathiJambunathan e34d212
fix bug in declaring uy uy new and computing uzp
RevathiJambunathan b8569b9
set particle Geom, BA, and DMAP for particle flush with plotfile
RevathiJambunathan b808533
set Particle BA Geom DMAP for particle buffer and no BTD transform f…
RevathiJambunathan 8125893
separate compute and pack from flush
RevathiJambunathan 50f73fb
Fix Typo: resizeable -> resizable
ax3l 381670b
new class for plotfile particles for BTD
RevathiJambunathan 0a71513
copy particle_H and DATA and Header. some WIP print statements
RevathiJambunathan 0d6bd0d
Merge plotfile
RevathiJambunathan 766ec50
clean print statements
RevathiJambunathan f5d74b5
fix warning message
RevathiJambunathan ef4031b
struct declaration in header, fix warning
RevathiJambunathan 3804b7f
doxygen comments and copyright
RevathiJambunathan 397151f
clean print statements
RevathiJambunathan 1bb369e
fix eol and override function warning
RevathiJambunathan 48e3498
tile data
RevathiJambunathan 6dd5f98
fix output species array size bug
RevathiJambunathan 20628db
fix access for particle buffer size
RevathiJambunathan 9623ce9
clean and move time-update
RevathiJambunathan e5f5ccd
add cur_time update back
RevathiJambunathan b3e3b6c
remove cur time update which was called twice
RevathiJambunathan cd95481
dont access particles flushed already for full diagnostics
RevathiJambunathan c954e07
cur time must be updated for RigidInjection BTD CI test to pass
RevathiJambunathan 497c092
temporarily move call to BTD
RevathiJambunathan d1ad9da
updating time and calling BTD before movewindow
RevathiJambunathan bb4a688
cleanup
RevathiJambunathan fa838aa
reset benchmarks and analysis script
RevathiJambunathan e93eee9
clean and add comments
RevathiJambunathan 6329a4e
fix particle box array, geom, dmap
RevathiJambunathan 86812c3
reset benchmarks for multi_J rz and ElectrostaticSphereEB_mixedBC
RevathiJambunathan 3922be6
wip commit
RevathiJambunathan a3d6749
wip commit
RevathiJambunathan e054ec9
add SI conversion
RevathiJambunathan 07c209c
abort for openpmd bp backend if species is selected. Also write parti…
RevathiJambunathan 3c8ecf4
add documentation for aborting if adios is used with openpmd and add …
RevathiJambunathan 9c59b86
Apply suggestions from code review
RevathiJambunathan 8fcf502
use bool instead of int
RevathiJambunathan 627117e
fix doxygen format
RevathiJambunathan 8838326
using h5 as backend in example test to ensure consistency with abort …
RevathiJambunathan 513cda9
fix doxygen comment
RevathiJambunathan 9d4b653
reset benchmark again for comoving_2d_psatd galilean_2d_psatd multi_J…
RevathiJambunathan e820996
reset benchmark for background_mcc
RevathiJambunathan 5bd5eb8
self-review suggestions
RevathiJambunathan 0202ea7
reset benchmarks. Update with last snapshot full info
RevathiJambunathan 6bffb51
Axel's PR suggestions
RevathiJambunathan 1e4ad4d
Axel's doxygen fix
RevathiJambunathan 9a6f674
add comments
RevathiJambunathan c625382
fix eol
RevathiJambunathan d36c05d
improved exception handling for stringsteam
RevathiJambunathan 66c9b96
PR suggestions
RevathiJambunathan 84a10a5
Axels' suggestions from code review
RevathiJambunathan 8200b1f
Axel's suggestions :)
RevathiJambunathan 3bd54a1
simplify logic
RevathiJambunathan 8070131
suggestions from review (Axel/Reva)
RevathiJambunathan 1b5959e
variable name change for clarity
RevathiJambunathan aaa727a
if num particles in tmp array is 0, return
RevathiJambunathan 8f82d77
Use new BTD inputs to set up BTD for particles in the corresponding p…
RevathiJambunathan 49f7fd3
unused var
RevathiJambunathan 70229e9
fix logic error
RevathiJambunathan 0ae5ce1
speciesID undefined
RevathiJambunathan 62a6c20
separate particle and field buffer calls and initialization for BTD. …
RevathiJambunathan e140b1e
rename variable so it does not ghost existing varname
RevathiJambunathan 41aebd7
add more comments
RevathiJambunathan fb849cd
Assert that fields are on
RevathiJambunathan c3ac1c2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 87bce0a
redundant function definition
RevathiJambunathan 68dc68b
unused variable
RevathiJambunathan 37ace97
unused variable zp
RevathiJambunathan 6d82387
1D 2D 3D definition
RevathiJambunathan 2e7cf66
fix else
RevathiJambunathan 7e0da5c
Apply suggestions from code review
RevathiJambunathan 380b176
missing semicolon and ignore xp yp for 1D
RevathiJambunathan a251387
resetting benchmarks for boosted sims and mcc sim
RevathiJambunathan 707f8e3
temporarily changing tolerance since the relative difference for mome…
RevathiJambunathan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roelof-groenewald I changed this temporarily to 3.7e-3 as that was the relative difference for particle_momentum_z for electrons. All other quantities in the checksum are within this tolerance. Was 2.5e-3 chosen specifically or was this driven by the maximum difference in the checksum?
This PR changes when time get updated, and as a result, background_mcc benchmarks are updated since the potential hi uses the updated time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds fine. The 2.5e-3 tolerance was not intelligently chosen, but by the needed tolerance for the test to pass so increasing it to 3.7e-3 is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!