openPMD: Handle Zero Particles Well #2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a time step for output encounters zero particles in a species, then we still want to dump them as "empty" species in openPMD. That simplifies post-processing a lot and we have the mechanisms in openPMD for it :)
ax3l
added
bug
This was referenced Mar 17, 2022
ax3l
changed the title
ax3l
force-pushed
the
fix-openPMD-zero-particles-step
branch
from
679334e to
3dd14cb
Compare
Write empty records for iterations (steps or lab steps for BTD, respectively) without particles in a species.
ax3l
force-pushed
the
fix-openPMD-zero-particles-step
branch
from
3dd14cb to
b6e7271
Compare
guj
reviewed
Mar 18, 2022
- set attributes once - set constant records once - clean up into appropriate functions
Works now as well 🎉
There was a problem hiding this comment.
This looks good to me.
Thank you for this PR @ax3l !
I have minor suggestions in the comments
Thank you!! :) Co-authored-by: Revathi Jambunathan <41089244+RevathiJambunathan@users.noreply.github.com>
RevathiJambunathan
approved these changes
Mar 21, 2022
ax3l
commented
Oct 5, 2022
Comment on lines
+1009
to
+1010
| currSpecies["charge"][scalar].makeConstant( charge ); | ||
| currSpecies["mass"][scalar].makeConstant( mass ); |
There was a problem hiding this comment.
Oops, 2x forgot resetDataset. Fixed in #3451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a time step for output encounters zero particles in a species, then we still want to dump them as "empty" species (for a step) in openPMD. That simplifies post-processing a lot and we have the mechanisms in openPMD for it :)
This also enables ADIOS
.bpsupport for BTD :)Fix #2900
Partly a follow-up to #1898, but mostly a missing implementation for zero particle cases.
To Do
makeEmpty())