Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: RTD urllib3 #3896

Merged
merged 1 commit into from
May 5, 2023
Merged

Fix: RTD urllib3 #3896

merged 1 commit into from
May 5, 2023

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented May 5, 2023 •
edited
Loading

Use a newer Ubuntu that ships a recent OpenSSL when building Sphinx with RTD. This migrates a broken dependency for urllib3 in version 3+.

  File "/home/docs/checkouts/readthedocs.org/user_builds/warpx/envs/3883/lib/python3.7/site-packages/sphinx/builders/linkcheck.py", line 18, in <module>
    from requests import Response
  File "/home/docs/checkouts/readthedocs.org/user_builds/warpx/envs/3883/lib/python3.7/site-packages/requests/__init__.py", line 43, in <module>
    import urllib3
  File "/home/docs/checkouts/readthedocs.org/user_builds/warpx/envs/3883/lib/python3.7/site-packages/urllib3/__init__.py", line 39, in <module>
    "urllib3 v2.0 only supports OpenSSL 1.1.1+, currently "
ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with OpenSSL 1.0.2n  7 Dec 2017. See: https://github.com/urllib3/urllib3/issues/2168

X-ref: urllib3/urllib3#2168

@ax3l
Fix: RTD
606269c 
Use a newer Ubuntu that ships a recent OpenSSL when building
Sphinx with RTD. This migrates a broken dependency for urllib3
in version 3+.
@ax3l ax3l added bug Something isn't working component: documentation Docs, readme and manual component: third party Changes in WarpX that reflect a change in a third-party library labels May 5, 2023
@ax3l ax3l requested a review from RemiLehe May 5, 2023 18:11
@ax3l ax3l changed the title Fix: RTD Fix: RTD urllib3 May 5, 2023
@RemiLehe RemiLehe merged commit 930ebe3 into ECP-WarpX:development May 5, 2023
@EZoni EZoni mentioned this pull request May 5, 2023
Merged
@ax3l ax3l deleted the fix-rtd-urllib branch May 5, 2023 21:46
@SeverinDiederichs SeverinDiederichs mentioned this pull request May 6, 2023
Merged
9 tasks
@hXtreme hXtreme mentioned this pull request May 7, 2023
Open
This was referenced May 9, 2023
Merged
Merged
ax3l added a commit to AMReX-Microelectronics/artemis that referenced this pull request May 10, 2023
@ax3l
Fix: RTD urllib3
cb74fca 
Use a newer Ubuntu that ships a recent OpenSSL when building Sphinx with readthedocs (RTD). This migrates a broken dependency for urllib3 in version 3+.

Same as ECP-WarpX/WarpX#3896
@ax3l ax3l mentioned this pull request May 10, 2023
Merged
lucafedeli88 pushed a commit to lucafedeli88/WarpX that referenced this pull request May 25, 2023
@ax3l @lucafedeli88
Fix: RTD (ECP-WarpX#3896)
08baf2e 
Use a newer Ubuntu that ships a recent OpenSSL when building
Sphinx with RTD. This migrates a broken dependency for urllib3
in version 3+.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemiLehe RemiLehe RemiLehe approved these changes

Assignees
No one assigned
Labels
bug Something isn't working component: documentation Docs, readme and manual component: third party Changes in WarpX that reflect a change in a third-party library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ax3l @RemiLehe