Fixing bug that only applied last field in the list of external field… #5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. Changed to add all fields. Signed-off-by: S. Eric Clark <25495882+clarkse@users.noreply.github.com>
clarkse
added
bug
Signed-off-by: S. Eric Clark <25495882+clarkse@users.noreply.github.com>
roelof-groenewald
approved these changes
Feb 20, 2025
dpgrote
reviewed
Feb 20, 2025
| ablastr::fields::MultiLevelVectorField B_ext = | ||
| warpx.m_fields.get_mr_levels_alldirs(FieldType::hybrid_B_fp_external, warpx.finestLevel()); | ||
| ablastr::fields::MultiLevelVectorField E_ext = | ||
| warpx.m_fields.get_mr_levels_alldirs(FieldType::hybrid_E_fp_external, warpx.finestLevel()); | ||
|
|
||
| // Zero E and B external fields prior to accumulating external fields |
|
Can you add or update the CI test to check multiple applied fields? |
I can split the applied field to exercise the list functionality. |
…wo equal components that are invoked through file reading and the implcit analytical field loading to exercise both options as well as test functionality for multiple external fields. Signed-off-by: S. Eric Clark <25495882+clarkse@users.noreply.github.com>
|
CI tests updated related to PR to #5275 RZ compression tests yield: |
Signed-off-by: S. Eric Clark <25495882+clarkse@users.noreply.github.com>
|
3D cylinder compression results test run to completion.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s. Changed to add all fields.
This bug cropped up during code review and refactoring. I have re-implemented the field accumulations for multiply defined external fields. This was not caught by CI since the cylinder compression test only has a single uniform compression field.