Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Also consider it a crash if doComparison is False and the return code is non-zero #1

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Jan 22, 2020

We apparently don't consider a non-zero exit code a failure unless self.run_as_script is True. When doing plotfile comparisons, this isn't a big issue, since the comparison itself will fail as the test did not produce any output. However, when we run through travis we turn off comparisons, so we need to check the exit code.

An alternative fix would be to consider all non-zero exit codes a failure. In principle I prefer this, but I don't know the reasoning behind the original behavior here, so I'd like to be conservative.

@atmyers atmyers requested a review from ax3l January 22, 2020 20:01
@ax3l ax3l requested a review from RemiLehe January 22, 2020 20:46
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@ax3l ax3l merged commit 0e6c888 into master Jan 22, 2020
@ax3l ax3l deleted the travis_false_passes branch January 22, 2020 20:47
@ax3l
Copy link
Member

ax3l commented Jan 22, 2020

for a follow-up: As @atmyers outlined above, I would also prefer to consider all non-zero exit codes, in good unix manner, an error.
Shall we try this @RemiLehe @MaxThevenet?
We probably just have to check that WarpX' executables return 0 on --help|-h and non-zero on input file errors, etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants