This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
Also consider it a crash if doComparison is False and the return code is non-zero #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We apparently don't consider a non-zero exit code a failure unless
self.run_as_script
isTrue
. When doing plotfile comparisons, this isn't a big issue, since the comparison itself will fail as the test did not produce any output. However, when we run through travis we turn off comparisons, so we need to check the exit code.An alternative fix would be to consider all non-zero exit codes a failure. In principle I prefer this, but I don't know the reasoning behind the original behavior here, so I'd like to be conservative.