Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of Kokkos macro aliases #58

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

sslattery
Copy link
Collaborator

We are in the process of deprecating the macros in Cabana_Macros.hpp with the goal of that file eventually being removed. This PR removes the use of those macros in the library implementation.

@sslattery sslattery self-assigned this Jan 4, 2019
@sslattery sslattery requested a review from dalg24 January 4, 2019 16:16
@codecov-io
Copy link

codecov-io commented Jan 4, 2019

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #58   +/-   ##
======================================
  Coverage    97.8%   97.8%           
======================================
  Files          15      15           
  Lines         731     731           
======================================
  Hits          715     715           
  Misses         16      16
Impacted Files Coverage Δ
core/src/Cabana_Slice.hpp 100% <ø> (ø) ⬆️
core/src/Cabana_VerletList.hpp 99.1% <ø> (ø) ⬆️
core/src/Cabana_ExecutionPolicy.hpp 100% <ø> (ø) ⬆️
core/src/Cabana_Sort.hpp 100% <ø> (ø) ⬆️
core/src/Cabana_AoSoA.hpp 100% <ø> (ø) ⬆️
core/src/Cabana_SoA.hpp 100% <ø> (ø) ⬆️
core/src/Cabana_LinkedCellList.hpp 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce733cd...88e2313. Read the comment docs.

@sslattery sslattery merged commit a87790d into ECP-copa:master Jan 4, 2019
@sslattery sslattery deleted the remove_cabana_macros branch January 4, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants