Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Cuda testing on Jenkins #78

Merged
merged 3 commits into from
Mar 12, 2019
Merged

Setup Cuda testing on Jenkins #78

merged 3 commits into from
Mar 12, 2019

Conversation

dalg24
Copy link
Collaborator

@dalg24 dalg24 commented Mar 7, 2019

Note that all existing PRs will need to be rebased on these changes for Jenkins build to work.

@dalg24 dalg24 requested a review from sslattery March 7, 2019 13:08
@dalg24
Copy link
Collaborator Author

dalg24 commented Mar 7, 2019

@sslattery The AoSoA test did not pass. I suggest we fix this in another PR.

As you see if you follow this link the build hooks are in place and seem to work. Some adjustment might be needed in the Jenkins configuration (possibly the white list for the trigger) but I granted you and Christoph permissions to edit it.

Copy link
Member

@junghans junghans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet another CI system? Didn’t we wanted to install a gitlab runner on that machine?

@dalg24
Copy link
Collaborator Author

dalg24 commented Mar 7, 2019

Yet another CI system? Didn’t we wanted to install a gitlab runner on that machine?

GitLab does not mirror the PRs.

@junghans
Copy link
Member

junghans commented Mar 7, 2019

Their idea of verification is that a developer review external PRs and push the sha on a local branch, which will trigger gitlab CI!

@junghans
Copy link
Member

junghans commented Mar 7, 2019

Their idea of verification is that a developer review external PRs and push the sha on a local branch, which will trigger gitlab CI!

It seems this broke like a month ago.

@junghans
Copy link
Member

junghans commented Mar 7, 2019

We are back in business!

@junghans
Copy link
Member

junghans commented Mar 7, 2019

And it seems gitlab.com triggers pull requests automatically now!

@dalg24
Copy link
Collaborator Author

dalg24 commented Mar 7, 2019

Closing per #19 (comment) and disabling the job on the Jenkins server

@dalg24 dalg24 closed this Mar 7, 2019
@junghans
Copy link
Member

junghans commented Mar 7, 2019

https://gitlab.com/gitlab-org/gitlab-ee/issues/5667 confuses me. I am not sure why your fork got triggered

@dalg24
Copy link
Collaborator Author

dalg24 commented Mar 12, 2019

Reopening since #79 is not able to address #19 at this time

@dalg24 dalg24 reopened this Mar 12, 2019
@codecov-io
Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #78   +/-   ##
======================================
  Coverage    97.7%   97.7%           
======================================
  Files          17      17           
  Lines        1100    1100           
======================================
  Hits         1075    1075           
  Misses         25      25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1cbe48...67a2f65. Read the comment docs.

@dalg24
Copy link
Collaborator Author

dalg24 commented Mar 12, 2019

Merged #80 that fixed the test failure into that branch. The build did not trigger on Jenkins though. Will look into it.

@dalg24
Copy link
Collaborator Author

dalg24 commented Mar 12, 2019

Went to the GitHub webhooks settings and redelivered the payload. Build passed. Let me do a rebase or something similar to re-trigger and be 100% sure it works now.

@dalg24
Copy link
Collaborator Author

dalg24 commented Mar 12, 2019

Build triggered. This is ready to merged.

@dalg24
Copy link
Collaborator Author

dalg24 commented Mar 12, 2019

@junghans @sslattery NOTE the CI is only setup for PRs at this time.

@dalg24 dalg24 requested a review from junghans March 12, 2019 22:10
@junghans junghans merged commit d8ee1af into ECP-copa:master Mar 12, 2019
@dalg24 dalg24 deleted the jenkins branch March 14, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants