Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ArborX neighbor list generation to work with ArborX 2.0 #803

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

aprokop
Copy link
Collaborator

@aprokop aprokop commented Jan 29, 2025

This version of the code should allow running Cabana against both ArborX v1 and v2.

@streeve streeve mentioned this pull request Feb 4, 2025
@aprokop
Copy link
Collaborator Author

aprokop commented Feb 6, 2025

So, the checks passe with 1.7. I think it would be helpful if we split ArborX builds in CI to run some with 1.7, and some with master. I don't know if it's easy/possible. But at least, we could make the nightly one run with ArborX master.

@aprokop
Copy link
Collaborator Author

aprokop commented Feb 6, 2025

@streeve Version 2.0 is not currently tagged or released. You would need master.

@streeve
Copy link
Member

streeve commented Feb 6, 2025

@streeve Version 2.0 is not currently tagged or released. You would need master.

Thanks, forgot about that

@streeve streeve self-requested a review February 6, 2025 16:24
Copy link
Member

@streeve streeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@streeve streeve merged commit ac3dc54 into ECP-copa:master Feb 7, 2025
34 checks passed
@aprokop aprokop deleted the arborx-2.0 branch February 7, 2025 18:27
@aprokop
Copy link
Collaborator Author

aprokop commented Feb 7, 2025

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants