Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply clang format style from Cabana #28

Merged
merged 6 commits into from
Jul 30, 2021
Merged

Apply clang format style from Cabana #28

merged 6 commits into from
Jul 30, 2021

Conversation

aetx
Copy link
Collaborator

@aetx aetx commented Jul 26, 2021

Just applied the clang format style from Cabana.

streeve
streeve reviewed Jul 26, 2021
View reviewed changes
Copy link
Member

@streeve streeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you copy the cmake/FindCLANG_FORMAT.cmake from Cabana and add to CMake?

@aetx
Copy link
Collaborator Author

aetx commented Jul 26, 2021

Done. Although when running make format I get the error error: cannot use -i when reading from stdin. Is there something else to consider than just adding the package and target to the main CMakeLists.txt? I do not get the error in Cabana.

streeve
streeve reviewed Jul 26, 2021
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@aetx @streeve
update filepaths for clang-format
acb4f03 
Co-authored-by: Sam Reeve <6740307+streeve@users.noreply.github.com>
@streeve streeve requested a review from junghans July 26, 2021 16:53
@junghans junghans requested a review from sslattery July 26, 2021 16:58
junghans
junghans requested changes Jul 26, 2021
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@aetx @junghans
fix missing extension dots in glob
cfcdf8b 
Co-authored-by: Christoph Junghans <christoph.junghans@gmail.com>
@streeve
Copy link
Member

streeve commented Jul 26, 2021

@junghans is it finding a newer clang-format?

@junghans
Copy link
Member

@junghans is it finding a newer clang-format?

Yes, any clang-format can be used, only if it is called clang-format-XX (XX>10) then is won't pick it up.

@junghans
Copy link
Member

Could NOT find CLANG_FORMAT: Found unsuitable version "0.0", but required is at least "10" (found /usr/bin/clang-format)
Not sure why it detected 0.0.

@junghans
Copy link
Member

ping @sslattery your call!

@junghans
Copy link
Member

@streeve can port 34805d0 back to Cabana as well?

@junghans
Copy link
Member

@streeve git am is magic: ECP-copa/Cabana#440

@streeve streeve merged commit 819442a into ECP-copa:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streeve streeve streeve approved these changes

@junghans junghans junghans approved these changes

@sslattery sslattery Awaiting requested review from sslattery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aetx @streeve @junghans