added UI for forgot-password step 1 2 and 3 #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divy-arpit
changed the title
werainkhatri
requested changes
Feb 27, 2021
There was a problem hiding this comment.
- reduce the size of Step 2/3 in the enter otp step
- Add a resend button, add its fake functionality and center align the resend and verify buttons. refer the design. Add a timer as in the design. (Your can refer this) Discuss with the designer.
- Add a back button, add the icon and change the title of the screen (to Verify your screen) according to the design.
- Add horizontal padding to the fields in reset password step
- Add the route to
main.dart(in routes), its name tostrings.dartandlogin.dart(navigator.of(context).pushNamed())
| ), | ||
| rightButtonFn: () { | ||
| setState(() { | ||
| otpEntered = otpEntered.substring(0, otpEntered.length - 1); |
There was a problem hiding this comment.
An error is thrown here (RangeError) when you click on right button (backspace) and otpEntered is empty. Add a check or something to prevent that.
Comment on lines
473
to
475
| if (bottom > height * 0.25) { | ||
| _scrollController.animateTo( | ||
| bottom - height * 0.25, |
There was a problem hiding this comment.
this should be 0.5 instead of 0.25
Hard-Coder05
requested changes
Feb 27, 2021
| @@ -163,6 +163,13 @@ packages: | |||
| url: "https://pub.dartlang.org" | |||
| source: hosted | |||
| version: "0.16.1" | |||
| js: | |||
There was a problem hiding this comment.
please revert the changes made in pubspe.lock
Also pull the latest code and remove the conflicts
changed the size of 2/3 and removed RangeError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
Description
Added UI for the forgot password screen
Type of Change: (Delete irrelevant options)
Code
User Interface
Code/Quality Assurance Only (Delete irrelevant options)
How Has This Been Tested?
Tested on local machine.
Checklist:
Code/Quality Assurance
Mention the dependencies/packages/plugins that have been added (if any)