Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1781 split eddi project revised #1815

Merged
merged 8 commits into from
Jun 16, 2020
Merged

Feature/1781 split eddi project revised #1815

merged 8 commits into from
Jun 16, 2020

Conversation

richardbuckle
Copy link
Member

Fixes #1781
Replaces #1796

@richardbuckle richardbuckle mentioned this pull request Jun 9, 2020
Closed
@richardbuckle
Copy link
Member Author

For my part, I am signed off on this.

GioVAX
GioVAX approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@GioVAX GioVAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tabs and adding the project to the solution!

I'll check my IDE tab settings to avoid this in the future :)

Tkael
Tkael reviewed Jun 10, 2020
View reviewed changes
EddiCore/Properties/AssemblyInfo.cs
using System.Runtime.InteropServices;
using System.Windows;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused using with using System.Windows;

@richardbuckle richardbuckle merged commit 976dccd into develop Jun 16, 2020
@richardbuckle richardbuckle deleted the feature/1781-SplitEddiProject branch June 16, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GioVAX GioVAX GioVAX approved these changes

@Tkael Tkael Tkael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split EDDI project into EddiCore and EddiApp
3 participants
@richardbuckle @Tkael @GioVAX