Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase request size limit #158

Closed
Athanasius opened this issue Jan 6, 2022 · 1 comment · Fixed by #159
Closed

Increase request size limit #158

Athanasius opened this issue Jan 6, 2022 · 1 comment · Fixed by #159

Comments

@Athanasius
Copy link
Contributor

Checking the apache logs I spotted some 413 Too Large responses being sent back in response to /upload/ requests.

It turns out that the python bottle module has a default request body size limit of 100KiB.

It should be possible to tweak a setting to increase this limit.

We probably also want to attempt adding some logging to know the nature of the requests that were (before this tweak) failing, to be sure they're not actually bad senders in some manner.

@Athanasius
Copy link
Contributor Author

For the record, it turned out all the 'over-sized' requests were navroute messages.

Some discussion in EDCD #eddn lead to a conclusion that probable max this could ever be is around 1.2MB (200 bytes, 6,000 jumps). We'll stay with 1MiB limit and try to implement some monitoring/reporting so we're aware if there's a need to further increase it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant