Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we handle 413 from EDDN properly #1390

Closed
Athanasius opened this issue Jan 7, 2022 · 2 comments · Fixed by #1409
Closed

Ensure we handle 413 from EDDN properly #1390

Athanasius opened this issue Jan 7, 2022 · 2 comments · Fixed by #1409
Assignees
@A-UNDERSCORE-D
Labels
EDDN enhancement
Milestone
5.3.0

Comments

@Athanasius
Copy link
Contributor

It recently came to light that EDDN has a maximum accepted message size . If any message is larger than this then the sender will receive an HTTP 413 status code.

We need to ensure that we handle this sanely. In particular ensure that such a message (probably a large navroute) doesn't cause any subsequent EDDN messages to be blocked.
@Athanasius
Copy link
Contributor Author

Side note: We don't currently gzip our sent messages, we could start doing that so as to mostly avoid the issue.

@Athanasius Athanasius added this to the 5.3.0 milestone Jan 20, 2022
@A-UNDERSCORE-D A-UNDERSCORE-D self-assigned this Jan 20, 2022
A-UNDERSCORE-D added a commit to A-UNDERSCORE-D/EDMarketConnector that referenced this issue Jan 20, 2022
@A-UNDERSCORE-D
Compress outgoing EDDN data if its large
508af99 
This is a sidestep solution to EDCD#1390. It doesn't attempt to directly
resend data, only compressing with gzip over a given size. If that STILL
returns a 413, its dropped, as without introspection of the message we
cannot make it any smaller
@A-UNDERSCORE-D A-UNDERSCORE-D mentioned this issue Jan 20, 2022
Merged
@A-UNDERSCORE-D A-UNDERSCORE-D linked a pull request Jan 20, 2022 that will close this issue
Compress outgoing EDDN data if its large #1409
Merged
A-UNDERSCORE-D added a commit to A-UNDERSCORE-D/EDMarketConnector that referenced this issue Jan 25, 2022
@A-UNDERSCORE-D
Compress outgoing EDDN data if its large
96b73c5 
This is a sidestep solution to EDCD#1390. It doesn't attempt to directly
resend data, only compressing with gzip over a given size. If that STILL
returns a 413, its dropped, as without introspection of the message we
cannot make it any smaller
A-UNDERSCORE-D added a commit to A-UNDERSCORE-D/EDMarketConnector that referenced this issue Jan 26, 2022
@A-UNDERSCORE-D
Compress outgoing EDDN data if its large
b780b1a 
This is a sidestep solution to EDCD#1390. It doesn't attempt to directly
resend data, only compressing with gzip over a given size. If that STILL
returns a 413, its dropped, as without introspection of the message we
cannot make it any smaller
@Athanasius
Copy link
Contributor Author

I think we tested the merged branch to my satisfaction, so closing this to clear down 5.3.0 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@A-UNDERSCORE-D A-UNDERSCORE-D

Labels
EDDN enhancement
Projects
None yet
Milestone
5.3.0
Development

Successfully merging a pull request may close this issue.

Compress outgoing EDDN data if its large A-UNDERSCORE-D/EDMarketConnector
2 participants
@Athanasius @A-UNDERSCORE-D