Compress outgoing EDDN data if its large #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Athanasius
reviewed
Jan 24, 2022
Athanasius
reviewed
Jan 24, 2022
Athanasius
reviewed
Jan 24, 2022
Athanasius
reviewed
Jan 24, 2022
Athanasius
reviewed
Jan 24, 2022
Athanasius
reviewed
Jan 24, 2022
Athanasius
reviewed
Jan 24, 2022
Athanasius
reviewed
Jan 24, 2022
A-UNDERSCORE-D
force-pushed
the
fix/1390/Ensure-we-handle-`413`-from-EDDN-properly
branch
from
7ef9263 to
c10ec20
Compare
Athanasius
reviewed
Jan 25, 2022
Athanasius
reviewed
Jan 25, 2022
HTTP utils are anything generally useful for HTTP things, currently thats just compressing a string if its larger than a given number of bytes. These libraries are intended to be available to plugins
This is a sidestep solution to EDCD#1390. It doesn't attempt to directly resend data, only compressing with gzip over a given size. If that STILL returns a 413, its dropped, as without introspection of the message we cannot make it any smaller
A-UNDERSCORE-D
force-pushed
the
fix/1390/Ensure-we-handle-`413`-from-EDDN-properly
branch
from
c10ec20 to
e891ee4
Compare
Athanasius
reviewed
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sidestep solution to #1390. It doesn't attempt to directly resend data, only compressing with gzip over a given size. If that STILL returns a 413, its dropped, as without introspection of the message we cannot make it any smaller