Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship is not displaying but IS hotlinked #614

Closed
msteele999 opened this issue Jul 19, 2020 · 16 comments
Closed

Ship is not displaying but IS hotlinked #614

msteele999 opened this issue Jul 19, 2020 · 16 comments
Labels

Comments

@msteele999
Copy link

Describe the bug
Version: 4.0.2.0
Windows 7 Pro Home

Regardless of display mode, the Ship name is not displayed but it IS linked and will open shipyard web interface.

Expected behavior
Ship name (i.e. DiamondBack Explorer) should be displayed.

Screenshots
Screenshot_071920_015759_PM

Desktop (please complete the following information):

  • OS: Windows 7 Home Pro
  • If applicable: Browser [e.g. chrome, safari]
  • Version 4.0.2.0
@msteele999 msteele999 added bug unconfirmed An unconfirmed bug labels Jul 19, 2020
@Athanasius
Copy link
Contributor

If this occurs without the game running, but then hitting 'Update' to get the UI to populate then it might be related to the name symbol for 'DiamondBack Explorer' in Frontier CAPI data not being properly mapped to a 'human' name. In this case we would need you to use 'File' > 'Save Raw Data' and attach the resulting file to this bug report.

Otherwise we would need you to attach the most recent Journal file from when this happens to this bug report. shell:SavedGames\Frontier Developments\Elite Dangerous.

Does this happen if:

  1. Your last game session included actually logging fully into the game, not just into the Main Menu.
  2. You exit the game
  3. You re-run EDMarketConnector.

In this state the application would be picking up your most recently used ship from the Journal file and the bug is something to do with the parsing of that file and/or subsequent processing. In this case

@Athanasius
Copy link
Contributor

Wait, what is your ship name? Not the model, the name you can assign to it in livery ?

@msteele999
Copy link
Author

msteele999 commented Jul 19, 2020 via email

@Athanasius
Copy link
Contributor

If you didn't then it's possible the CAPI might be putting that '_' in for some reason. We'll need the 'Save Raw Data' output to be sure.

@msteele999
Copy link
Author

msteele999 commented Jul 20, 2020 via email

@Athanasius
Copy link
Contributor

Athanasius commented Jul 20, 2020

Raw Data Save attached.

It doesn't look like those come through via email. Please come to GitHub (URL is in the email) and attach it in a comment.

@msteele999
Copy link
Author

Attached via github interface

Pro Eurl VG-K c22-12.2020-07-20T14.24.04.zip

@Athanasius
Copy link
Contributor

Hmmm, that does indeed have ship->name as DiamondBackXL. I'll do some testing with this tomorrow. Thanks.

@msteele999
Copy link
Author

msteele999 commented Jul 20, 2020 via email

@Athanasius
Copy link
Contributor

I can get a blank ship name to show up. Just purchase any ship, then log out and back in. There's blank ShipName in the LoadOut journal event and EDMC uses that. But that doesn't explain the reporter seeing _ as the name!

@Athanasius
Copy link
Contributor

aha! That _ is because you get a space character there, or otherwise minimum URL text and it shows on mouse over in the default EDMC skin. OK, this just needs some code to check for ShipName = ''.

@Athanasius
Copy link
Contributor

No, it's actually because you get:

 "event":"Loadout", "Ship":"diamondbackxl", "ShipID":31, "ShipName":" ",

in the journal after a relog! So, here's hoping no-one WANTS to call their ship <literal space character>.

@Athanasius
Copy link
Contributor

Yup, easy fix. This will be in whatever is the next full release after 4.0.2.0. Probably a 4.0.3 once we nail down the fix for #616

@msteele999
Copy link
Author

msteele999 commented Jul 22, 2020 via email

@Athanasius
Copy link
Contributor

Please try out 4.0.3-rc3 .

NB: If you happened to try any of the earlier 4.0.3-rcX series please uninstall EDMC first, then install -rc3. All your configuration and third-party plugins will be unaffected (assuming you put third-party plugins in the correct place, not the install folder!).

@Athanasius
Copy link
Contributor

Closed as 4.0.3 is now out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants