Investigate & fix wrong-commander EDSM data #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just the parsing and storage of the options for now.
* trace-on 'edsm-cmdr-events' for how Commanders, their API keys and using them are handled. See #1134 * trace-on 'edsm-locations' for what was commented-out logging to do with ensuring code reacted correctly to any change of system. * mypy/types-* seem to have had changes causing extra carping, so addressing that.
We MUST attempt flushing pending events in case of commander change.
We need to trigger off ShutDown and Commander/LoadGame to empty pending, so need to *see* them in the worker.
…ould_send() * Ensure we have the discarded_events list *before* starting to consume events. There's the *same* risk as before with EDSM just being down and us queueing up more and more, just now it will be in the worker queue rather than pending. * We need to test for some events in should_send() that are in the discard list, and thus will never be in the `entries` (pending) passwd in, so pass in the name of the latest event as well.
This prevents literally sending an empty data to EDSM if we trigger sending due to Shutdown.
A-UNDERSCORE-D
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is aimed at addressing #1134 .
To start with it's adding some logging, including the new EDMarketConnector.exe
--trace-on ...CL arg for activating specific TRACE logging.