EDDN: Implement fsssignaldiscovered/1 schema
#1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge Develop in
Athanasius
changed the title
fsssignaldiscovered/1 schemafsssignaldiscovered/1 schema
* Move call to `export_journal_fsssignaldiscovered` to top-level of event
processing. This ensures we'd still have the *previous* system tracked
when running under Odyssey.
Also, we can't return any result from this, as we'd still need to process
things like `Location` otherwise.
* Use `logger.trace_if("plugin.eddn.fsssignaldiscovered", ...)`
* Perform all sanity checks, elisions and augmentations in the "not
FSSSignalDiscovered event" sending code.
* Need to remove `event`, `horizons` and `odyssey` per signal. * It's lower case `horizons` and `odyssey` in a(n augmented) journal event. * It's `event`, not `entry` that `export_journal_entry()` will look for.
|
This has been tested against the schema now live on beta.eddn.edcd.ioi, under both Horizons and Odyssey.
The results can be seen at https://edgalaxydata.space/EDDN/beta/Unknown-2022-06-15.jsonl . The first few messages there are from before I correctly elided some things. Good messages are from |
A-UNDERSCORE-D
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @chennin 's initial work in #1586
Closes #1589